[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #117071)
Zequan Wu via lldb-commits
lldb-commits at lists.llvm.org
Thu Nov 21 13:06:51 PST 2024
ZequanWu wrote:
> if you're sending things for presubmit checks, but not for precommit review, please include the `skip-precommit-approval` label
Good to know that.
> - but in this case it looks like you requested review, but then submitted without waiting for that review? Please don't do that, per: https://llvm.org/docs/CodeReview.html#code-review-workflow
>
> > Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed.
Okay, I should just commit directly for this kind of relanding.
https://github.com/llvm/llvm-project/pull/117071
More information about the lldb-commits
mailing list