[Lldb-commits] [lldb] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 21 13:02:53 PST 2024


================
@@ -3278,7 +3278,7 @@ bool AppleObjCRuntimeV2::NonPointerISACache::EvaluateNonPointerISA(
       }
 
       // If the index is still out of range then this isn't a pointer.
-      if (index > m_indexed_isa_cache.size())
+      if (index >= m_indexed_isa_cache.size())
----------------
bulbazord wrote:

This fixes this bound check, but there's the exact same bounds check above on line 3228. I don't see that mentioned in the blog post's analysis. From the comments above line 3228, that should be changed as well, no?

https://github.com/llvm/llvm-project/pull/117226


More information about the lldb-commits mailing list