[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

[via lldb-commits]

https://github.com/jimingham commented:

It would be marginally nicer if there were some way to have "a shared pointer that can't be empty" to express the fact that we are always going to put something in the result_valobj_sp, so you didn't have to check it for null.  That's the intent of Evaluate at this point.  But I'm not sure how you would express that.

This is strictly better than what was there before, so LGTM.

https://github.com/llvm/llvm-project/pull/117186