[Lldb-commits] [lldb] [lldb] Make sure completions don't end with newlines (PR #117054)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> I get the "description" part, but I'm somewhat confused about the "completion". How does a newline (trailing or not) get there? Like, you can't actually type something which includes a newline, right? I'm wondering if we should disallow these at a higher level...

I didn't actually find a completion where that was the case, but it seemed simple enough to be defensive for both. Like I said in the description, I considered an assertion but technically this is user input. I didn't actually try this, but what I was thinking of is something like a newline in `DW_AT_name` or something. Obviously that's not something reasonable tools would generate, but input is input... 

https://github.com/llvm/llvm-project/pull/117054