[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 19 16:28:52 PST 2024


================
@@ -259,22 +256,19 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges(
     }
   }
 
-  if (ranges.IsEmpty()) {
-    if (lo_pc != LLDB_INVALID_ADDRESS) {
-      if (hi_pc != LLDB_INVALID_ADDRESS && hi_pc > lo_pc)
-        ranges.Append(DWARFRangeList::Entry(lo_pc, hi_pc - lo_pc));
-      else
-        ranges.Append(DWARFRangeList::Entry(lo_pc, 0));
-    }
+  if (ranges.empty() && lo_pc != LLDB_INVALID_ADDRESS) {
+    ranges.emplace_back(
+        lo_pc, (hi_pc != LLDB_INVALID_ADDRESS && hi_pc > lo_pc) ? hi_pc : 0);
----------------
bulbazord wrote:

The possibilities for the 2nd argument went from `hi_pc - lo_pc` or `0` to `hi_pc` or `0`. Is this intentional? I'm not sure if the format is now `(base address, length)` or `(low address, high address)`.

https://github.com/llvm/llvm-project/pull/116620


More information about the lldb-commits mailing list