[Lldb-commits] [lldb] [lldb] Reword the "line 0" warning (PR #116827)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 19 08:54:00 PST 2024
================
@@ -2007,19 +2007,9 @@ bool StackFrame::GetStatus(Stream &strm, bool show_frame_info, bool show_source,
if (num_lines != 0)
have_source = true;
// TODO: Give here a one time warning if source file is missing.
- if (!m_sc.line_entry.line) {
- ConstString fn_name = m_sc.GetFunctionName();
-
- if (!fn_name.IsEmpty())
- strm.Printf(
- "Note: this address is compiler-generated code in function "
- "%s that has no source code associated with it.",
- fn_name.AsCString());
- else
- strm.Printf("Note: this address is compiler-generated code that "
- "has no source code associated with it.");
- strm.EOL();
- }
+ if (!m_sc.line_entry.line)
+ strm << "Note: This address is not associated with a specific line "
----------------
JDevlieghere wrote:
```suggestion
strm << "note: This address is not associated with a specific line "
```
It's a bit awkward with the full sentences, but for consistency we should make `note:` lowercase (like `error:` and `warning:`)
https://github.com/llvm/llvm-project/pull/116827
More information about the lldb-commits
mailing list