[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

[Michael Buch via lldb-commits]

Michael137 wrote:

> LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/8268
> 
> Here is the relevant piece of the build log for the reference
> ```
> Step 6 (test) failure: build (failure)
> ...
> PASS: lldb-api :: python_api/target/TestTargetAPI.py (1104 of 2050)
> PASS: lldb-api :: symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py (1105 of 2050)
> PASS: lldb-api :: symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py (1106 of 2050)
> PASS: lldb-api :: test_utils/TestDecorators.py (1107 of 2050)
> PASS: lldb-api :: terminal/TestSTTYBeforeAndAfter.py (1108 of 2050)
> PASS: lldb-api :: test_utils/TestInlineTest.py (1109 of 2050)
> PASS: lldb-api :: test_utils/TestPExpectTest.py (1110 of 2050)
> PASS: lldb-api :: test_utils/base/TestBaseTest.py (1111 of 2050)
> PASS: lldb-api :: symbol_ondemand/shared_library/TestSharedLibOnDemand.py (1112 of 2050)
> UNSUPPORTED: lldb-api :: tools/lldb-dap/breakpoint-events/TestDAP_breakpointEvents.py (1113 of 2050)
> FAIL: lldb-api :: tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py (1114 of 2050)
> ******************** TEST 'lldb-api :: tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py' FAILED ********************
> Script:
> --
> /usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/make --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/tools/lldb-dap/breakpoint -p TestDAP_breakpointLocations.py
> --
> Exit Code: 1
> 
> Command Output (stdout):
> --
> lldb version 20.0.0git (https://github.com/llvm/llvm-project.git revision 4f48a81a620bc9280be4780f3554cdc9bda55bd3)
>   clang revision 4f48a81a620bc9280be4780f3554cdc9bda55bd3
>   llvm revision 4f48a81a620bc9280be4780f3554cdc9bda55bd3
> Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']
> ========= DEBUG ADAPTER PROTOCOL LOGS =========
> 1731780632.250944853 --> 
> Content-Length: 344
> 
> {
>   "arguments": {
>     "adapterID": "lldb-native",
>     "clientID": "vscode",
>     "columnsStartAt1": true,
>     "linesStartAt1": true,
>     "locale": "en-us",
>     "pathFormat": "path",
>     "sourceInitFile": false,
>     "supportsRunInTerminalRequest": true,
>     "supportsStartDebuggingRequest": true,
>     "supportsVariablePaging": true,
>     "supportsVariableType": true
>   },
>   "command": "initialize",
>   "seq": 1,
>   "type": "request"
> }
> 1731780632.252939463 <-- 
> Content-Length: 1631
> ```

This is also failing on the macOS CI: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15438/execution/node/97/log/
```
======================================================================
FAIL: test_column_breakpoints (TestDAP_breakpointLocations.TestDAP_setBreakpoints)
   Test retrieving the available breakpoint locations.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py", line 77, in test_column_breakpoints
    self.assertEqual(
AssertionError: Lists differ: [{'co[70 chars]e': 41}, {'column': 3, 'line': 42}, {'column': 18, 'line': 42}] != [{'co[70 chars]e': 42}, {'column': 18, 'line': 42}]

First differing element 2:
{'column': 3, 'line': 41}
{'column': 3, 'line': 42}

First list contains 1 additional elements.
First extra element 4:
{'column': 18, 'line': 42}

  [{'column': 39, 'line': 40},
   {'column': 51, 'line': 40},
-  {'column': 3, 'line': 41},
   {'column': 3, 'line': 42},
   {'column': 18, 'line': 42}]
Config=arm64-/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang
----------------------------------------------------------------------
Ran 1 test in 1.554s

FAILED (failures=1)
```

Mind taking a look?

https://github.com/llvm/llvm-project/pull/113787