[Lldb-commits] [lldb] [lldb][test] Add test categories for Linux and Darwin tests (PR #116194)

[Vladislav Dzhidzhoev via lldb-commits]

dzhidzhoev wrote:

> Is the real, underlying problem that `skipUnlessDarwin` is checking the host platform instead of the target platform? I'm somewhat worried about adding a category that (at first glance) competes with the existing decorators and the associated risk of folks misunderstanding/misusing them.

No, regarding "darwin", it's about these tests from here https://lab.llvm.org/staging/#/builders/197/builds/363/steps/17/logs/stdio
```
PASS: lldb-api :: macosx/load-kext/TestLoadKext.py (995 of 1211)
PASS: lldb-api :: macosx/duplicate-archive-members/TestDuplicateMembers.py (996 of 1211)
PASS: lldb-api :: macosx/version_zero/TestGetVersionZeroVersion.py (1017 of 1211)
```
There are no decorators in them.

> I'm somewhat worried about adding a category that (at first glance) competes with the existing decorators and the associated risk of folks misunderstanding/misusing them.

I agree with that. Maybe they should be renamed somehow to emphasize that it's for builbot purposes, not for failing/unsupported tests? Like `macosx-oriented`?

https://github.com/llvm/llvm-project/pull/116194