[Lldb-commits] [lldb] [lldb][test] Add test categories for Linux and Darwin tests (PR #116194)
Vladislav Dzhidzhoev via lldb-commits
lldb-commits at lists.llvm.org
Thu Nov 14 03:02:10 PST 2024
dzhidzhoev wrote:
> How are you going to use these categories exactly? Is this level of detail enough for your use case?
The initial idea was to disable tests from `lldb/test/API/macosx` directory on lldb-remote-linux-* builders. Most of them are already disabled, but they're disabled with varying predicates, like `@skipUnlessDarwin` or `@skipIf(debug_info=no_match("dsym"))`.
The five tests left may not be very interesting for testing on these buildbot configurations, such as TestLoadKext.py. But turning them completely off on non-Darwin targets would not be good, since, as @labath said, the goal of tests' portability is pursued. That's why I added a category here.
Then, I thought it'd be better to add categories not only for Darwin but also for Windows and Linux for completeness. Similarly, `lldb/test/API/linux/` can be skipped on lldb-remote-linux-win buildbot, as they're gonna be run on lldb-remote-linux-linux. However, for the Windows category, I haven't found a matching directory to turn tests from it off :). I can remove it if we only don't want to add categories "in advance".
https://github.com/llvm/llvm-project/pull/116194
More information about the lldb-commits
mailing list