[Lldb-commits] [lldb] [LLDB] Add framework for Data Inspection Language (DIL) work. (PR #115666)

via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 11 16:09:19 PST 2024


jimingham wrote:

IIUC, the goal is that In the end, DIL will win and there will only be one VariableExpressionPath interface lldb.  So it seems inefficient for the interim stage to introduce another function and switch between them with UseDIL all over the code.  Why not leave GetValueForVariableExpressionPath for now, and move the `if (UseDIL())` into that function.  They have the same signature, and you'll always be able to find the target from the ValueObject when you are in GetValueForVariableExpressionPath, so that should be possible.

That will make the diff much smaller, and in the end mean that pulling the switch to use only the DIL will be less disruptive.

https://github.com/llvm/llvm-project/pull/115666


More information about the lldb-commits mailing list