[Lldb-commits] [clang] [lldb] [llvm] [AArch64] Reduce +sve2-aes to an alias of +sve-aes+sve2 (PR #114293)

via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 10 11:14:05 PST 2024


================
@@ -6,10 +6,10 @@ tbx z0.b, z1.b, z2.b
 // CHECK: error: instruction requires: sve2 or sme
 // CHECK-NEXT: tbx z0.b, z1.b, z2.b
 
-.arch_extension sve2-aes
-.arch_extension nosve2-aes
+.arch_extension sve-aes
+.arch_extension nosve-aes
----------------
SpencerAbson wrote:

That's because all `sve2-aes` does is enable `sve2` and `sve-aes` (which these instructions are guarded by). The following sequence:
```
.arch_extension sve2-aes
.arch_extension nosve2-aes
```

Would still allow the use of `aesd`, because disabling a specific feature does not disable it's dependencies. You raise a good point with this comment, we may need to reconsider if this is the intended behavior.

In either case, I should not have removed the positive tests for `sve2-aes` so I'll fix that.

https://github.com/llvm/llvm-project/pull/114293


More information about the lldb-commits mailing list