[Lldb-commits] [lldb] [lldb] Transfer some environment variables into the tests on Windows build host (PR #115613)
via lldb-commits
lldb-commits at lists.llvm.org
Sat Nov 9 09:13:28 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
<details>
<summary>Changes</summary>
Some API tests (compiler calls) create a lot of garbage and cause unexpected behavior in case of Windows host and Linux target, e.g.
```
lldb/test/API/commands/process/attach/%SystemDrive%/
lldb/test/API/functionalities/deleted-executable/%SystemDrive%/
lldb/test/API/functionalities/exec/%SystemDrive%/
lldb/test/API/functionalities/load_unload/%SystemDrive%/
lldb/test/API/functionalities/target-new-solib-notifications/%SystemDrive%/
lldb/test/API/functionalities/thread/create_after_attach/%SystemDrive%/
```
It can be fixed by transfer some standard Windows environment variables into API tests.
---
Full diff: https://github.com/llvm/llvm-project/pull/115613.diff
1 Files Affected:
- (modified) lldb/test/API/lit.cfg.py (+19)
``````````diff
diff --git a/lldb/test/API/lit.cfg.py b/lldb/test/API/lit.cfg.py
index 6ef09f36a1907e..febf8dc3d19021 100644
--- a/lldb/test/API/lit.cfg.py
+++ b/lldb/test/API/lit.cfg.py
@@ -334,3 +334,22 @@ def delete_module_cache(path):
# Propagate XDG_CACHE_HOME
if "XDG_CACHE_HOME" in os.environ:
config.environment["XDG_CACHE_HOME"] = os.environ["XDG_CACHE_HOME"]
+
+# Transfer some environment variables into the tests on Windows build host.
+if platform.system() == "Windows":
+ for v in [
+ "SystemDrive",
+ "SystemRoot",
+ "ALLUSERSPROFILE",
+ "APPDATA",
+ "LOCALAPPDATA",
+ "USERDNSDOMAIN",
+ "USERDOMAIN",
+ "USERNAME",
+ "USERPROFILE",
+ "USERDOMAIN_ROAMINGPROFILE",
+ "COMPUTERNAME",
+ "ProgramData",
+ ]:
+ if v in os.environ:
+ config.environment[v] = os.environ[v]
``````````
</details>
https://github.com/llvm/llvm-project/pull/115613
More information about the lldb-commits
mailing list