[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

[Adrian Vogelsgesang via lldb-commits]

================
@@ -1465,11 +1462,7 @@ CreateRunInTerminalReverseRequest(const llvm::json::Object &launch_request,
     llvm::StringRef key = envs.GetNameAtIndex(index);
     llvm::StringRef value = envs.GetValueAtIndex(index);
 
-    if (key.empty())
-      g_dap.SendOutput(OutputType::Stderr,
-                       "empty environment variable for value: \"" +
-                           value.str() + '\"');
-    else
----------------
vogelsgesang wrote:

> In lldb I can use `settings set target.env-vars FOO=` [...]

Note that this warning warns about `key.empty()`, not `value.empty()`, i.e. for `=FOO` and not `FOO=`.

That being said, I am also not sure how much value this warning provides

https://github.com/llvm/llvm-project/pull/115561