[Lldb-commits] [lldb] [lldb] Fixed the @skipUnlessAArch64MTELinuxCompiler decorator (PR #115480)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 8 05:23:52 PST 2024


https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/115480

It is broken after #115337

https://lab.llvm.org/buildbot/#/builders/195/builds/794

>From 091a21534bfdb043b3e9bea7156bcb483b179b1e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Fri, 8 Nov 2024 17:22:43 +0400
Subject: [PATCH] [lldb] Fixed the @skipUnlessAArch64MTELinuxCompiler decorator

It is broken after #115337

https://lab.llvm.org/buildbot/#/builders/195/builds/794
---
 lldb/packages/Python/lldbsuite/test/decorators.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 0bb9ab9f5f8929..c48c0b2f779449 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -997,7 +997,10 @@ def is_toolchain_with_mte():
         f.close()
 
         cmd = f"{compiler_path} -x c -o {f.name} -"
-        if subprocess.run(cmd, input="int main() {}".encode()).returncode != 0:
+        if (
+            subprocess.run(cmd, shell=True, input="int main() {}".encode()).returncode
+            != 0
+        ):
             os.remove(f.name)
             # Cannot compile at all, don't skip the test
             # so that we report the broken compiler normally.
@@ -1014,7 +1017,7 @@ def is_toolchain_with_mte():
                 void* ptr = __arm_mte_create_random_tag((void*)(0), 0);
             }"""
         cmd = f"{compiler_path} -march=armv8.5-a+memtag -x c -o {f.name} -"
-        res = subprocess.run(cmd, input=test_src.encode())
+        res = subprocess.run(cmd, shell=True, input=test_src.encode())
         os.remove(f.name)
         if res.returncode != 0:
             return "Toolchain does not support MTE"



More information about the lldb-commits mailing list