[Lldb-commits] [lldb] [lldb-dap] Refactoring breakpoints to not use the `g_dap` reference. (PR #115208)

[Walter Erquinigo via lldb-commits]

walter-erquinigo wrote:

> With these changes, and the fact that BreakpointBase has a DAP& member, the breakpoints cannot be copied. 

I don't see that as a problem, but if at some point we need some more flexibility, we should be able to use std::reference_wrapper to store the ref and then allow for copies of objects when it makes sense.

> I do wonder if we should further refactor the types in lldb-dap to be a little more like clangd where we have a more distinct protocol representation with toJSON/fromJSON JSON serialization support (e.g. https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/Protocol.h).

100%! 

https://github.com/llvm/llvm-project/pull/115208