[Lldb-commits] [lldb] [lldb-dap] Refactoring breakpoints to not use the `g_dap` reference. (PR #115208)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Thu Nov 7 01:13:43 PST 2024
================
@@ -7,10 +7,19 @@
//===----------------------------------------------------------------------===//
#include "Breakpoint.h"
-#include "DAP.h"
+
#include "JSONUtils.h"
+
+#include "lldb/API/SBAddress.h"
#include "lldb/API/SBBreakpointLocation.h"
+#include "lldb/API/SBLineEntry.h"
+
#include "llvm/ADT/StringExtras.h"
+#include "llvm/Support/JSON.h"
+
+#include <stddef.h>
+#include <stdint.h>
+#include <string>
----------------
labath wrote:
```suggestion
#include "JSONUtils.h"
#include "lldb/API/SBAddress.h"
#include "lldb/API/SBBreakpointLocation.h"
#include "lldb/API/SBLineEntry.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/JSON.h"
#include <cstddef>
#include <cstdint>
#include <string>
```
(I've replaced the c headers with c++ equivalents. I've also put the includes back into a separate group, which is the LLVM style and ensures clang-format will group them into the [preferred order](https://llvm.org/docs/CodingStandards.html#include-style). LLDB does not stick to that much, but I don't see a reason to regress that here)
https://github.com/llvm/llvm-project/pull/115208
More information about the lldb-commits
mailing list