[Lldb-commits] [lldb] eee8718 - [lldb][test] TestDataFormatterLibcxxOptionalSimulator.py: skip on Clang-17

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2024-11-04T11:23:11Z
New Revision: eee8718e26b4ce8972abefc35d2beae96521075f

URL: https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f
DIFF: https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f.diff

LOG: [lldb][test] TestDataFormatterLibcxxOptionalSimulator.py: skip on Clang-17

A Clang change introduced in this version breaks this test. Said
change was reverted in `52a9ba7ca4fb9427706c28bb3ca15f7a56eecf3f`
in newer versions of Clang.

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py
index 7167f4c6c9b5b1..3fefe87dcad970 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/optional/TestDataFormatterLibcxxOptionalSimulator.py
@@ -47,6 +47,12 @@ def _run_test(self, defines):
     name = f"test_r{r}"
     defines = [f"REVISION={r}"]
 
+    # LLDB's FormatterCache caches on DW_AT_name. A change introduced in
+    # clang-17 (commit bee886052) changed the contents of DW_AT_name for
+    # template specializations, which broke FormatterCache assumptions
+    # causing this test to fail. This was reverted in newer version of clang
+    # with commit 52a9ba7ca.
+    @skipIf(compiler="clang", compiler_version=["=", "17"])
     @functools.wraps(LibcxxOptionalDataFormatterSimulatorTestCase._run_test)
     def test_method(self, defines=defines):
         LibcxxOptionalDataFormatterSimulatorTestCase._run_test(self, defines)