[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 1 15:05:41 PDT 2024


================
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
   // Add a hint if object description was requested, but no description
   // function was implemented.
   auto maybe_add_hint = [&](llvm::StringRef output) {
+    static bool note_shown = false;
+    if (note_shown)
+      return;
----------------
JDevlieghere wrote:

I realize this code was already there, but this isn't great. Can we store this at the debugger level, for example? I'd expect this to show up once per debugger, and again after having called SBDebugger::Terminate/Initialize. 

https://github.com/llvm/llvm-project/pull/114608


More information about the lldb-commits mailing list