[Lldb-commits] [lldb] [lldb] Create dependent modules in parallel (PR #114507)
Dmitrii Galimzianov via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 31 22:09:11 PDT 2024
================
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ if (objfile) {
+ std::lock_guard<std::mutex> guard(dependent_files_mutex);
objfile->GetDependentModules(dependent_files);
----------------
DmT021 wrote:
I wonder if this operation is heavy in any of the `ObjectFile` implementations. If it is we may want to lock the mutex only when an actual append to the dependent_files happens.
https://github.com/llvm/llvm-project/pull/114507
More information about the lldb-commits
mailing list