[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 29 14:51:38 PDT 2024


Michael137 wrote:

Sorry to clarify. I think based on @felipepiovezan comment here: https://github.com/llvm/llvm-project/pull/108870#issuecomment-2444481588

On Clang 17 we compile fine, just the assertion fails to find the expected function name (because of the `std::__1` inline namespace):
```
FAIL: test_frame_recognizer (TestLibcxxInternalsRecognizer.LibCxxInternalsRecognizerTestCase)
   Test that implementation details of libc++ are hidden
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/libcxx-internals-recognizer/TestLibcxxInternalsRecognizer.py", line 60, in test_frame_recognizer
    self.assertIn(
AssertionError: 'ranges::__sort::operator()' not found in 'std::__1::__wrap_iter<int*> std::__1::ranges::__sort::__fn::operator()[abi:ue170006]<std::__1::__wrap_iter<int*>, std::__1::__wrap_iter<int*>, bool (*)(int, int), std::__1::identity>(std::__1::__wrap_iter<int*>, std::__1::__wrap_iter<int*>, bool (*)(int, int), std::__1::identity) const'
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/clang_1706_build/bin/clang
```

So really we should skip for <= 15. And fix the assertion for 17+

https://github.com/llvm/llvm-project/pull/114122


More information about the lldb-commits mailing list