[Lldb-commits] [lldb] [lldb][test] Skip libc++ tests if it is linked statically (PR #113935)

via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 28 09:41:43 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 8ae39c8e34de2d24c46827b324c76bac845c18b0...77b2ad3e3975ed5b4e0f23efd64999abc92175e7 lldb/packages/Python/lldbsuite/test/dotest.py lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- packages/Python/lldbsuite/test/dotest.py	2024-10-28 16:33:13.000000 +0000
+++ packages/Python/lldbsuite/test/dotest.py	2024-10-28 16:41:15.277640 +0000
@@ -774,11 +774,19 @@
     if lldbplatformutil.target_is_android() or lldbplatformutil.platformIsDarwin():
         return True, "libc++ always present"
 
     if platform == "linux":
         with tempfile.NamedTemporaryFile() as f:
-            cmd = [configuration.compiler, "-xc++", "-stdlib=libc++", "-l:libc++.so", "-o", f.name, "-"]
+            cmd = [
+                configuration.compiler,
+                "-xc++",
+                "-stdlib=libc++",
+                "-l:libc++.so",
+                "-o",
+                f.name,
+                "-",
+            ]
             p = subprocess.Popen(
                 cmd,
                 stdin=subprocess.PIPE,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,

``````````

</details>


https://github.com/llvm/llvm-project/pull/113935


More information about the lldb-commits mailing list