[Lldb-commits] [lldb] ba19e98 - [lldb][CMake] If make isn't found, print a warning but don't error out (#111531)

Stefan Gränitz via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 23 05:33:28 PDT 2024


Author: Stefan Gränitz
Date: 2024-10-23T14:32:58+02:00
New Revision: ba19e98ca5e4fbc05429edd96e09b5c75df57e3c

URL: https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c
DIFF: https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c.diff

LOG: [lldb][CMake] If make isn't found, print a warning but don't error out (#111531)

Bot maintainers should be aware and it became too much of a burden
for developers. In particular on Windows, where make.exe won't be
found in Path typically.

Added: 
    

Modified: 
    lldb/test/API/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt
index 2548cab5cfb5b8..36f4973ad9a452 100644
--- a/lldb/test/API/CMakeLists.txt
+++ b/lldb/test/API/CMakeLists.txt
@@ -57,9 +57,9 @@ else()
     message(STATUS "Found make: ${LLDB_DEFAULT_TEST_MAKE}")
   else()
     message(STATUS "Not found: make")
-    message(SEND_ERROR
-          "LLDB tests require 'make' tool. Please pass via `LLDB_TEST_MAKE` "
-          "(or otherwise disable tests with `LLDB_INCLUDE_TESTS=OFF`)")
+    message(WARNING
+          "Many LLDB API tests require 'make' tool. Please provide it in Path "
+          "or pass via LLDB_TEST_MAKE.")
   endif()
 endif()
 


        


More information about the lldb-commits mailing list