[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

[Michael Buch via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/112928 at github.com>


================
@@ -2771,6 +2771,9 @@ static bool GetCompleteQualType(clang::ASTContext *ast,
         ast, llvm::cast<clang::AttributedType>(qual_type)->getModifiedType(),
         allow_completion);
 
+  case clang::Type::MemberPointer:
+    return !qual_type.getTypePtr()->isIncompleteType();
----------------
Michael137 wrote:

I see, so for non-MSVC ABI `isIncompleteType` will pretty much work as before, and trivially return true. Otherwise we check for the `MSInheritanceAttr`. Seems reasonable to me

https://github.com/llvm/llvm-project/pull/112928