[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 19 02:32:06 PDT 2024


================
@@ -434,6 +442,19 @@ static void GetTypeLookupContextImpl(DWARFDIE die,
     auto push_ctx = [&](CompilerContextKind kind, llvm::StringRef name) {
       context.push_back({kind, ConstString(name)});
     };
+
+    // Since mangled names are unique there's no need to build an entire context.
+    if (use_mangled_name) {
----------------
Michael137 wrote:

If all that `use_mangled_name` is doing is to create a vector with 1 entry, which is the mangled name, can we just do so at the callsite of this function, instead of embedding it here?

https://github.com/llvm/llvm-project/pull/113007


More information about the lldb-commits mailing list