[Lldb-commits] [lldb] a01d7df - [lldb] Avoid repeated map lookups (NFC) (#112823)

via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 18 10:40:18 PDT 2024


Author: Kazu Hirata
Date: 2024-10-18T10:40:13-07:00
New Revision: a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0

URL: https://github.com/llvm/llvm-project/commit/a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0
DIFF: https://github.com/llvm/llvm-project/commit/a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0.diff

LOG: [lldb] Avoid repeated map lookups (NFC) (#112823)

Added: 
    

Modified: 
    lldb/source/Commands/CommandObjectMultiword.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Commands/CommandObjectMultiword.cpp b/lldb/source/Commands/CommandObjectMultiword.cpp
index 484d9022027ec6..b4cdfea9b1a3ef 100644
--- a/lldb/source/Commands/CommandObjectMultiword.cpp
+++ b/lldb/source/Commands/CommandObjectMultiword.cpp
@@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
 
   std::string str_name(name);
 
-  auto pos = m_subcommand_dict.find(str_name);
-  if (pos == m_subcommand_dict.end()) {
-    m_subcommand_dict[str_name] = cmd_obj_sp;
+  auto [pos, inserted] = m_subcommand_dict.try_emplace(str_name, cmd_obj_sp);
+  if (inserted)
     return llvm::Error::success();
-  }
 
   const char *error_str = nullptr;
   if (!can_replace)
@@ -117,7 +115,7 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
   if (error_str) {
     return llvm::createStringError(llvm::inconvertibleErrorCode(), error_str);
   }
-  m_subcommand_dict[str_name] = cmd_obj_sp;
+  pos->second = cmd_obj_sp;
   return llvm::Error::success();
 }
 


        


More information about the lldb-commits mailing list