[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

[Michael Buch via lldb-commits]

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/112735

>From 6da0d2a549418d86e8877564ba7c6ff7c56db2eb Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuch12 at gmail.com>
Date: Thu, 17 Oct 2024 16:52:48 +0100
Subject: [PATCH 1/2] [lldb][test][NFC] Document DYLIB_NAME Makefile variable

---
 lldb/packages/Python/lldbsuite/test/make/Makefile.rules | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index f81db9bc06d8a8..a2a8ae504053c6 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -13,6 +13,13 @@
 # the building of the a.out executable program.  For example,
 # DYLIB_ONLY := YES
 #
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "foo.<platform-specific-extension>",
+# which on Darwin will be "foo.dylib".
+#
+# DYLIB_NAME := foo
+#
 # Specifying FRAMEWORK and its variants has the effect of building a NeXT-style
 # framework.
 # FRAMEWORK := "Foo"

>From 00642f09bd1c18ec11b00f51520a877293011825 Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuch12 at gmail.com>
Date: Fri, 18 Oct 2024 09:46:37 +0100
Subject: [PATCH 2/2] fixup! clarify platform-dependent nature of the dylib
 name

---
 lldb/packages/Python/lldbsuite/test/make/Makefile.rules | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index a2a8ae504053c6..121d052fb5f374 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -14,9 +14,9 @@
 # DYLIB_ONLY := YES
 #
 # When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
-# controls the name of the produced dylib. E.g., if set to "foo",
-# the generated dylib will be called "foo.<platform-specific-extension>",
-# which on Darwin will be "foo.dylib".
+# controls the (platform-dependent) name of the produced dylib. E.g.,
+# on Darwin, if "DYLIB_NAME := foo", the generated dylib will be called
+# "foo.dylib".
 #
 # DYLIB_NAME := foo
 #