[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112823)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 17 23:47:59 PDT 2024


================
@@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
 
   std::string str_name(name);
 
-  auto pos = m_subcommand_dict.find(str_name);
-  if (pos == m_subcommand_dict.end()) {
-    m_subcommand_dict[str_name] = cmd_obj_sp;
+  auto [pos, inserted] = m_subcommand_dict.try_emplace(str_name, cmd_obj_sp);
+  if (inserted)
     return llvm::Error::success();
-  }
 
   const char *error_str = nullptr;
   if (!can_replace)
----------------
labath wrote:

I guess line 118 could also be `pos->second = cmd_obj_sp;`

https://github.com/llvm/llvm-project/pull/112823


More information about the lldb-commits mailing list