[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

[via lldb-commits]

jimingham wrote:

Note that a lot of lldb was written before C++11 was allowed in llvm projects.  So looking through code that hasn't been touched recently, you will likely find constructs that could be made more efficient with some of the newer C++ gadgets.  We probably shouldn't be doing change just for changes sake, but when we can make the code clearer or more efficient, that's certainly worth doing.

Jim


> On Oct 17, 2024, at 7:23 AM, Felipe de Azevedo Piovezan ***@***.***> wrote:
> 
> 
> Thanks for finding those, there are many places in LLDB doing repeated work like this!
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/112655#issuecomment-2419698547>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW6BHFPRYQ7CN6LZBQTZ37B67AVCNFSM6AAAAABQCZCHMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZGY4TQNJUG4>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/112655