[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 17 07:28:35 PDT 2024


https://github.com/labath commented:

This is exactly what I had in mind -- thank you.

The patch looks mostly good, apart from the inline comments. My main question is about the "dependant modules" parsing code. AFAICT, its not actually functional (and not tested). Is yaml2objs xcoff backend sufficiently developed to create a test for the dependant module functionality? Given that we rely on llvm for parsing that, we don't have to test it extensively, but it would be nice to have at least one test. We could either do that in this patch, or rip out the dependant module functionality, and add it back in another patch -- up to you.

https://github.com/llvm/llvm-project/pull/111814


More information about the lldb-commits mailing list