[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

[Pavel Labath via lldb-commits]

================
@@ -44,6 +44,8 @@
 #include "llvm/Support/MathExtras.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/MipsABIFlags.h"
+#include "lldb/Target/Process.h"
+
----------------
labath wrote:

btw, this grouping of include blocks with empty lines is an lldb-ism (other llvm subprojects don't have that), and one not very strictly adhered to (it looks like this file does not put lldb includes in a separate block). One problem with adding empty lines like that is that it prevents clang-format from sorting the includes. Right now clang-format (correctly) wants to put this include next to the other lldb includes. If you added an empty line, it would leave it alone, thinking that is intentional (which I don't think it is).

https://github.com/llvm/llvm-project/pull/112596