[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 16 16:47:51 PDT 2024


================
@@ -212,15 +209,14 @@ TEST_F(MainLoopTest, PendingCallbackTrigger) {
   ASSERT_TRUE(callback2_called);
 }
 
-// Regression test for assertion failure if a lot of callbacks end up
-// being queued after loop exits.
-TEST_F(MainLoopTest, PendingCallbackAfterLoopExited) {
+TEST_F(MainLoopTest, ManyPendingCallbacks) {
   MainLoop loop;
   Status error;
-  ASSERT_TRUE(loop.Run().Success());
-  // Try to fill the pipe buffer in.
+  // Try to fill up the pipe buffer and make sure bad things don't happen.
----------------
Jlalond wrote:

The prior comment I think better explained the purpose of the test (ensuring we terminate even if the pipe buffer is full). 

https://github.com/llvm/llvm-project/pull/112565


More information about the lldb-commits mailing list