[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

[Michael Buch via lldb-commits]

Michael137 wrote:

> > maybe we could just skip the test if we can't locate the module?
> 
> Can you suggest how to do that (locate the module)?

Instead of,
```
self.expect(                                                            
    lib_stdcxx, "Libraray StdC++ is located", exe=False, substrs=["lib"]
)                                                                       
``
Do,
```
if "lib" not in libstd_cxx:
  self.skipTest("This test requires libstdc++.so or libc++.dylib in the target's module list.")
```
 
> > Won't setting USE_LIBSTDCPP be an issue on Darwin?
> > I can't test on Darwin. Maybe the following?
> 
> ```
> ifneq ($(OS),Darwin)
>     USE_LIBSTDCPP := 1
> else
>     USE_SYSTEM_STDLIB := 1
> endif
> ```

Yea that would be an alternative. Don't really have a preference tbh, though the former seems more robust. @labath @DavidSpickett any thoughts?


https://github.com/llvm/llvm-project/pull/112357