[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 15 05:05:44 PDT 2024


https://github.com/labath approved this pull request.

LGTM.

For better or worse, I can reproduce the same behavior on linux when I put make in a path with spaces.

@slydiman has recently proposed (and I pushed back) overriding some variables (including `$(MAKE)`) to include the quotes. I like this better (despite some drawbacks) as we're not overriding a predefined variable, and is in line with the recommendation in https://stackoverflow.com/questions/23330243/gnu-makefile-how-to-and-when-to-quote-strings

https://github.com/llvm/llvm-project/pull/112342


More information about the lldb-commits mailing list