[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

[Stefan Gränitz via lldb-commits]

weliveindetail wrote:

Thanks for the quick feedback! Yes, the buildbot in https://lab.llvm.org/buildbot/#/builders/141 isn't affected.

Debug output (in swiftlang lldb) is:
```
Reading makefiles...
Updating goal targets....
 File `all' does not exist.
   File `a.out' does not exist.
     File `lib_shared' does not exist.
    Must remake target `lib_shared'.
make.exe: Entering directory `S:/b/5/lldb-test-build.noindex/functionalities/completion/TestCompletion.test_target_modules_search_paths_insert'
C:/Program Files (x86)/GnuWin32/bin/make.exe -f S:\SourceCache\llvm-project\lldb\packages\Python\lldbsuite\test\make/Makefile.rules \
                DYLIB_ONLY=YES DYLIB_CXX_SOURCES=shared.cpp DYLIB_NAME=shared
'C:/Program' is not recognized as an internal or external command,
operable program or batch file.
make.exe: *** [lib_shared] Error 1
```

Some more context:
* This a follow-up from our previous discussion here: https://github.com/llvm/llvm-project/pull/111531#review-thread-or-comment-id-1146601373
* Failures caused by this issue aren't obvious, because tests show up as `UNRESOLVED` (building the inferior seems to be considered a precondition)

https://github.com/llvm/llvm-project/pull/112342