[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

[via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/111531 at github.com>


zeroomega wrote:

> In fact, I ran into that on Friday myself. I checked `LLDB_INCLUDE_TESTS=Off` in my setup and it appeared to be incompatible with `LLDB_ENABLE_PYTHON=On` if `lldb-python` is part of `LLVM_DISTRIBUTION_COMPONENTS`. The error said something like `lldb-python-scripts` is lacking an `install-stripped` target. I couldn't fix that quickly and just wired up the `LLDB_TEST_MAKE` config.
> 
> @zeroomega Any similar experiences with `LLDB_INCLUDE_TESTS=Off`?

No, I didn't see this issue. Our build passed after I set `LLDB_INCLUDE_TESTS=Off` on our Windows bots.  But we also didn't set `lldb-python` in `LLVM_DISTRIBUTION_COMPONENTS`. We do have `lldb-python-scripts`. You can see our cmake invocation here: 
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8734080863088320417/+/u/build_and_install_lldb/configure/l_execution_details





https://github.com/llvm/llvm-project/pull/111531