[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 11 16:29:04 PDT 2024


================
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
   m_fallback.GetTypesWithQuery(query, callback);
 }
 
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+    ConstString name, const CompilerDeclContext &parent_decl_ctx,
+    llvm::function_ref<bool(DWARFDIE die)> callback) {
+  std::vector<lldb_private::CompilerContext> parent_contexts =
+      parent_decl_ctx.GetCompilerContext();
+  if (parent_contexts.empty())
+    return GetNamespaces(name, callback);
----------------
clayborg wrote:

Yeah, do we expect if "parent_decl_ctx" is empty that we return every namespace, or just top level ones? Depends on how this API is being used.

https://github.com/llvm/llvm-project/pull/110062


More information about the lldb-commits mailing list