[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 11 14:52:24 PDT 2024


JDevlieghere wrote:

> So, I have a couple of thoughts:
> 
> * the system log currently writes to stdout on windows. This was sort of okay, when we were writing there only sporadically, but I think piping all of that here would make lldb unusable. If we want to go down this path, I think we should make `Host::SystemLog` a noop on windows (until someone comes up with a better implementation)

https://github.com/llvm/llvm-project/pull/112052

Regarding limiting the output, I'm happy to draw the line at `LLDB_LOG_ERRORV`. The system log is pretty cheap on our platform and I assumed it's the same on Linux, so personally I would hope it doesn't deter anyone from using `LLDB_LOG_ERROR`. 

@adrian-prantl do you want the system log to include the dropped errors in `Status`. If so we'll need to promote that to use `LLDB_LOG_ERROR` instead. 

https://github.com/llvm/llvm-project/pull/111911


More information about the lldb-commits mailing list