[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 11 13:34:24 PDT 2024
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/111531 at github.com>
zeroomega wrote:
> > Not all lldb tests require `make` to run and it feels wrong to me to mandate `make` tool for a few tests that requires it.
>
> All the API tests build their inferior with Make and looking at the last successful run on Windows, we have 1206 API tests, 561 shell tests and 261 unit tests. Even if we only consider the ones that are passing, the API tests are still the vast majority. I'm not sure how you come to the conclusion that only "a few tests" require it?
Fine, let me just disable windows tests on our bots all together.
https://github.com/llvm/llvm-project/pull/111531
More information about the lldb-commits
mailing list