[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

[via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/111531 at github.com>


zeroomega wrote:

Hi,

I noticed that our LLDB Windows builders all failed after this change is landed:

```
CMake Error at C:/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/CMakeLists.txt:60 (message):
   LLDB tests require 'make' tool.  Please pass via `LLDB_TEST_MAKE` (or
   otherwise disable tests with `LLDB_INCLUDE_TESTS=OFF`)
```

We are aware our windows bots don't have make tool and we are not planning to add it anyway. Not all lldb tests require `make` to run and it feels wrong to me to mandate `make` tool for a few tests that requires it. Could it be changed to disable such tests when make is not present instead of throw an error to prevent the lldb build?

https://github.com/llvm/llvm-project/pull/111531