[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 11 11:39:57 PDT 2024


bulbazord wrote:

> I agree with that, but the argument here was going the other way. lldb-enumerations.h are a base set of enumerations that anybody using LLDB, either lldb_private or the SB API's are free to use. But the SB API's are purely wrappers around lldb_private API's, and so should never be used in lldb_private. If you put an SB API header in lldb-enumerations.h, now most of lldb_private is going to see it. Does that also fit wth your mental model? Jim

Generally no, though I kind of think the enumeration shouldn't belong in the API directory to begin with. I see Ismail changed that so it seems like we're on the same page here.

https://github.com/llvm/llvm-project/pull/111907


More information about the lldb-commits mailing list