[Lldb-commits] [lldb] [lldb] Fix finding make tool for tests (PR #111980)

[David Spickett via lldb-commits]

DavidSpickett wrote:

Putting this in review because I've zero idea why this fixes it. Without it I get this on a rebuild:
```
Traceback (most recent call last):
  File "/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 67, in test_reverse_continue_skip_breakpoint_async
    self.reverse_continue_skip_breakpoint_internal(async_mode=True)
  File "/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 70, in reverse_continue_skip_breakpoint_internal
    target, process, initial_threads = self.setup_recording(async_mode)
  File "/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 94, in setup_recording
    self.build()
  File "/home/david.spickett/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1496, in build
    self.runBuildCommand(command)
  File "/home/david.spickett/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1501, in runBuildCommand
    output = check_output(command, stderr=STDOUT, errors="replace")
  File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1738, in _execute_child
    and os.path.dirname(executable)
  File "/usr/lib/python3.10/posixpath.py", line 152, in dirname
    p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneType
Config=aarch64-/home/david.spickett/build-llvm-aarch64/bin/clang
```
Because the `make` passed in `command` is actually `None`. Perhaps the cache isn't read properly after the first configuration?

https://github.com/llvm/llvm-project/pull/111980