[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

[Michael Buch via lldb-commits]

https://github.com/Michael137 commented:

Thanks for putting this together! Looks like non-trivial amount of investigation.

On the first pass, I think this seems like a reasonable (and more maintainable) alternative to what we're currently doing.

Using the `TypeSystem` to fish out the various `std::function` details aligns with what we also do for the other libc++ data formatters.

Ultimately it would be nice to achieve the step-through-to-callable in a more compiler/thread-plan oriented way. But that's out of scope of this in my opinion, given we already have `FindLibCppStdFunctionCallableInfo`.

A high-level comment: could we split up `FindLibCppStdFunctionCallableInfo`? Exactly how I haven't fully thought through. But possibly a function for each of the possible callable cases?

I'll do a second pass of this early next week

https://github.com/llvm/llvm-project/pull/111892