[Lldb-commits] [lldb] [lldb][NFC] Fix a build failure with MSVC (PR #111231)
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 10 18:58:10 PDT 2024
adrian-prantl wrote:
> > Looks good, I guess. Is that constructor even necessary, given that it just forwards the argument to the base class, and we already have the forwarding `using` declaration?
>
> The constructor looks redundant at the moment, perhaps it is just a legacy from the early stages of patch #106442. Maybe some other constructors can also be reduced, for example, `Win32Error::Win32Error()`. However, I may not fully understand the intentions of the author of the original patch, so I'd prefer @adrian-prantl to do the cleanup if necessary. My patch is only intended to fix the immediate problem.
This constructor is more a leftover after a bunch of refactoring, your change LGTM!
https://github.com/llvm/llvm-project/pull/111231
More information about the lldb-commits
mailing list