[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

[via lldb-commits]

https://github.com/jimingham commented:

This layering seems wrong to me.  If you put an SB header in lldb-enumerations.h, then you are pretty much including it in all of lldb.  But SB defines should really only be used in include/lldb/API and source/API.
Note, SBLanguages.h itself seems wrong to me.  It is used to pass a language name enum to SBExpressionOptions::SetLanguage, which turns around and calls EvaluateExpressionOptions::SetLanguage, but in that API we call it a uint16_t.  Why didn't we make an lldb-languages.h and include that in some place that both the SB caller and the lldb API it wraps can share it on the up-and-up?

https://github.com/llvm/llvm-project/pull/111907