[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 11:17:31 PDT 2024


================
@@ -2078,6 +2078,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line,
 
     ElapsedTime elapsed(execute_time);
     cmd_obj->SetOriginalCommandString(real_original_command_string);
+    pos = real_original_command_string.rfind(remainder);
----------------
jimingham wrote:

IIUC, the indent gets incremented twice here.  The first time is here where you're just conveniently setting it to "past the command name" since commands don't get that part.  Then later if there's an error you bump the indent to the actual error.  That seems sufficiently tricky to warrant a comment?

https://github.com/llvm/llvm-project/pull/110901


More information about the lldb-commits mailing list