[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

Stefan Gränitz via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 02:32:08 PDT 2024


================
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
         "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
     endif()
   endforeach()
+
+  # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+  if(LLDB_TEST_MAKE)
+    set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
+  else()
+    find_program(LLDB_DEFAULT_TEST_MAKE make)
+    if(LLDB_DEFAULT_TEST_MAKE)
+      message(STATUS "Found make: ${LLDB_DEFAULT_TEST_MAKE}")
----------------
weliveindetail wrote:

@labath Thanks for your feedback! I already set up the follow-up. I will take your proposal into account. Hope it's ok to do it there: https://github.com/llvm/llvm-project/pull/111744

https://github.com/llvm/llvm-project/pull/111531


More information about the lldb-commits mailing list