[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

[Stefan Gränitz via lldb-commits]

================
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
         "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
     endif()
   endforeach()
+
+  # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+  if(LLDB_TEST_MAKE)
+    set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
+  else()
+    find_program(LLDB_DEFAULT_TEST_MAKE make)
+    if(LLDB_DEFAULT_TEST_MAKE)
+      message(STATUS "Found make: ${LLDB_DEFAULT_TEST_MAKE}")
----------------
weliveindetail wrote:

Well, no there is no GOOD reason. For the moment it was easy to keep it guarded by `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` since it is `OFF` by default and won't fall on people's feet immediately. However, I am afraid we should special-case NetBSD and FreeBSD here to look for `gmake` instead of `make`.

Let me fix this in a follow-up PR that includes the author of https://github.com/llvm/llvm-project/pull/93883

https://github.com/llvm/llvm-project/pull/111531