[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

[Jonas Devlieghere via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/111531 at github.com>


================
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
         "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
     endif()
   endforeach()
+
+  # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+  if(LLDB_TEST_MAKE)
+    set(LLDB_DEFAULT_TEST_MAKE ${LLDB_TEST_MAKE})
+  else()
+    find_program(LLDB_DEFAULT_TEST_MAKE make)
+    if(LLDB_DEFAULT_TEST_MAKE)
+      message(STATUS "Found make: ${LLDB_DEFAULT_TEST_MAKE}")
----------------
JDevlieghere wrote:

Is there a reason to conditionalize this on `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? I would hoist this up so that we always have CMake configure `make` and only conditionalize the warning. 

https://github.com/llvm/llvm-project/pull/111531