[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 14:10:48 PDT 2024


================
@@ -273,8 +273,14 @@ void ProcessMinidump::RefreshStateAfterStop() {
         // No stop.
         return;
       }
-
-      stop_info = StopInfo::CreateStopReasonWithSignal(*stop_thread, signo);
+      const char *description = nullptr;
+      if (exception_stream.ExceptionRecord.ExceptionFlags ==
+          llvm::minidump::Exception::LLDB_FLAG)
+        description = reinterpret_cast<const char *>(
----------------
Jlalond wrote:

So the string ref also takes a size parameter, so I created with that. The conversion to a c-string should cover the overflow case. Good callout

https://github.com/llvm/llvm-project/pull/108448


More information about the lldb-commits mailing list