[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 10:48:03 PDT 2024


https://github.com/JDevlieghere commented:

I like the idea of looking for Make at configuration time. However, I think if we go that route, we should pass make as an explicit argument to `dotest.py`:

 - We do for other tools that we find at configuration time (such as `dsymutil`).
 - It eliminates the possibility of `dotest.py` finding a different `make` than CMake. 

Looking at `dotest.py`, it already supports `--make` so hopefully this is trivial to hook up. 

https://github.com/llvm/llvm-project/pull/111531


More information about the lldb-commits mailing list